Skip to content

CI: re-enable st-onboard-a5 - #1563

Merged
ChaoWao merged 1 commit into
hw-native-sys:mainfrom
wangqin1723-max:ci-reenable-st-onboard-a5
Jul 29, 2026
Merged

CI: re-enable st-onboard-a5#1563
ChaoWao merged 1 commit into
hw-native-sys:mainfrom
wangqin1723-max:ci-reenable-st-onboard-a5

Conversation

@wangqin1723-max

@wangqin1723-max wangqin1723-max commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

The a5 self-hosted runner is back in service, so the job has a host to run on again. Restore its gate to the same shape as st-onboard-a2a3: gated solely by detect-changes' a5_changed flag, giving a5 changes silicon coverage rather than st-sim-a5 alone.

Drops the note about the repair along with the short-circuit it described — the condition it explained no longer exists.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 75a16882-c774-43df-871e-939117d9e7b2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The CI workflow re-enables the st-onboard-a5 job when detect-changes reports that A5 files changed.

Changes

A5 onboarding CI gating

Layer / File(s) Summary
Restore change-based job gating
.github/workflows/ci.yml		 The st-onboard-a5 condition now evaluates a5_changed without the hard-disabled false && prefix.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Poem

A bunny checks the workflow gate,
No longer closed by false’s weight.
When A5 changes hop in sight,
The onboarding job takes flight! 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the main change: re-enabling the st-onboard-a5 CI job.
Description check ✅ Passed The description directly matches the change, explaining the restored CI gate and removal of the obsolete short-circuit.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@wangqin1723-max
CI: re-enable the a5 self-hosted jobs
17e5064 
The a5 runner is back in service, so both jobs targeting it have a host
to run on again. Restore their gates to match their a2a3 counterparts:
ut-a5 gated on docs_only like ut-a2a3, st-onboard-a5 gated on a5_changed
like st-onboard-a2a3. a5 changes get silicon coverage again instead of
falling back to st-sim-a5 alone.

Drops the notes about the repair along with the short-circuits they
described — the condition they explained no longer exists.
@wangqin1723-max
wangqin1723-max force-pushed the ci-reenable-st-onboard-a5 branch from dc6a072 to 17e5064 Compare July 29, 2026 03:41
@ChaoWao
ChaoWao merged commit 8e00319 into hw-native-sys:main Jul 29, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wangqin1723-max @ChaoWao